Tim te Beek

Results 1243 comments of Tim te Beek

I think I finally narrowed it down to a change between these two versions: - https://github.com/spring-cloud/spring-cloud-kubernetes/blob/v3.1.1/spring-cloud-kubernetes-dependencies/pom.xml#L38 - https://github.com/spring-cloud/spring-cloud-kubernetes/blob/v3.1.2/spring-cloud-kubernetes-dependencies/pom.xml That dependency managed version was introduced a couple years before - https://github.com/spring-cloud/spring-cloud-kubernetes/issues/943...

Thanks for the detailed report! It seems we convert the configured paths to matchers on these lines, which then might need to be revised. https://github.com/openrewrite/rewrite-maven-plugin/blob/9fc5e1057e37828391b32415faf26049c90d9084/src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java#L174-L191

hi @maecval ; Thanks for the report! Can indeed confirm the issue with this unit test added to https://github.com/openrewrite/rewrite-spring/blob/70153755a1077235c1064e01b0703898ce0a650d/src/testWithSpringBoot_2_4/java/org/openrewrite/java/spring/boot2/UnnecessarySpringExtensionTest.java#L29 ```java @Issue("https://github.com/openrewrite/rewrite-spring/issues/678") @Test void retainSecondary() { //language=java rewriteRun( java( """ import...

Would welcome a draft PR that adds that test, and then whatever you can do to explore a fix. I imagine we'll want to explore the ExtendsWith annotation here: https://github.com/openrewrite/rewrite-spring/blob/70153755a1077235c1064e01b0703898ce0a650d/src/main/java/org/openrewrite/java/spring/boot2/UnnecessarySpringExtension.java#L84...

Oh wow, thanks for reporting the issues you're finding! Seems like a straightforward special case replacement to get this fixed.

Thanks for reporting your new findings @jeffreye ! Seems indeed like that case isn't covered yet; would you want to help out with a unit test on a draft PR,...

So this has likely been improved by our addition of Lombok support.

Very strange that you're seeing differences on those two Java versions. You might want to check the very latest Gradle plugin version, as I see you're using an older version...

We just merged a fix for a very similar issue, there affecting static imports of variables, not methods: - https://github.com/openrewrite/rewrite/pull/4450 Figured that might be interesting to call out here as...

Reading this issue again I think it's logged against the wrong project. With the changes since it's hard to say if this has been solved or not; If you feel...