Tim te Beek
Tim te Beek
I think you're on to the issue there; I don't have more insights, but I would expect that `case "//"` to set `inSingleLineComment = true`, probably just as you would....
Great! Thanks again for diving in. Running all the tests is a good start. Beyond that we can run against a few large projects to test
Great! Now would be the time to push a commit to a branch on your fork at https://github.com/rahul3509/rewrite, and then follow the prompts to create a pull request here. I'll...
I've pushed up a PR just now crediting you for the fix @rahul3509 ; Figured easiest to see this resolved quickly as @mccartney was interested in a fix to this...
Thanks for the help! Feel free to start a draft pull request with a new failing test and explore from there. There's also been some earlier related work in this...
Thanks a lot for the continued improvements to the Groovy parser @sudouser777 ! Great to see steady progress being made. Any reason you'd held off on a merge here @greg-at-moderne...
Copying the failure we're seeing here for easier reference: ``` DestructuringTest > destructuringWithType() FAILED java.lang.AssertionError: Source file was parsed into an LST that contains non-whitespace characters in its whitespace. This...
Asking @jkschneider for a final review, as he suggested to introduce the `G.DestructuringDeclaration` element, and we want to ensure the design aligns with what he had intended, especially as LST...
No worries; I hope all is well there. We'll try to work this in, unless you beat us to it. :)
Thanks both! I'm not likely to get to a review this week with travel ahead, but perhaps @MBoegers can have a look while I'm out.