Tim te Beek
Tim te Beek
hi @skazaruddin ! Not quite sure what's going on for you; we explicitly have tests that validate the timeout parsing: https://github.com/openrewrite/rewrite/blob/c97c7f214634c78b257e6a7eb6705727f3d46900/rewrite-maven/src/test/java/org/openrewrite/maven/MavenSettingsTest.java#L344-L371 Here's a list of the fields we map for...
Thanks for splitting off these changes! I do see some overlap in the files changed and in - #4330 Since we squash merge; would it be possible to minimize the...
> That being said, in case we are not on the same page, every change set from the last PR #4330 is also included in this one, so you could...
This PR seems to have amassed quite some conflicts since it was opened. I'm also not sure we'd want to support a new `Boolean changePropertyVersionName` option. Perhaps we should instead...
Thanks again for logging the issue both in Slack and again here. Indeed perhaps easiest to start with always adding managed dependencies at the top if there's any dependency BOM...
@gjd6640 I've had a quick go to try to replicate the issue you've reported, arriving at this unit test added to https://github.com/openrewrite/rewrite/blob/345a8f29998d218f8d5b4e75d2d4a1e826b48a9a/rewrite-maven/src/test/java/org/openrewrite/maven/AddManagedDependencyTest.java#L27 ```java @Test @Issue("https://github.com/openrewrite/rewrite/issues/4337") void overrideShouldPrecedeBom() { rewriteRun( spec...
Closing because this has failed to replicate, and we do not have any new input to see when this occurs.
Hi! Quick bit of answer to give some context, as it's hard to dive deep into each reported issue. The `` you're seeing in tests is a marker that's printed...
As to what to do: You can update your test expectation to include that marker, and rest assured it's not produced in practice. That's a bit icky I agree. The...
Linking the [lines shown in the screenshot](https://github.com/apache/avro/blob/bd9f9680b16197aab6cf61e77ff7929aa46ee690/lang/java/protobuf/src/test/java/org/apache/avro/protobuf/multiplefiles/A.java#L81-L85) here. Not immediately clear which recipe ran to produce this error. I propose we close this issue given the amount of changes since,...