rewrite icon indicating copy to clipboard operation
rewrite copied to clipboard

Maven RemoveProperty - does not clean up empty properties tag

Open nmck257 opened this issue 2 years ago • 1 comments

When RemoveProperty removes the last/only property in a pom.xml, then it would be nice if it also removed the empty <properties> tag. The existing recipe logic is trivial and does not attempt to handle this case.

nmck257 avatar May 10 '23 20:05 nmck257

Ideally tackled by calling out to the dedicated recipe in

  • https://github.com/openrewrite/rewrite/issues/2737
  • https://github.com/openrewrite/rewrite/pull/3613

Through something like

doAfterVisit(new RemoveEmptyXmlTags().getVisitor());

timtebeek avatar May 14 '23 21:05 timtebeek

Am I correct in thinking 9fed57a465e7bd70f546bbb67c824abbd7ff4f69 resolves this issue?

nielsdebruin avatar Oct 02 '24 14:10 nielsdebruin

Indeed that's tackled since! Thanks for helping clear out the backlog. 🙏

timtebeek avatar Oct 06 '24 16:10 timtebeek