rewrite
rewrite copied to clipboard
Maven RemoveProperty - does not clean up empty properties tag
When RemoveProperty removes the last/only property in a pom.xml, then it would be nice if it also removed the empty <properties> tag. The existing recipe logic is trivial and does not attempt to handle this case.
Ideally tackled by calling out to the dedicated recipe in
- https://github.com/openrewrite/rewrite/issues/2737
- https://github.com/openrewrite/rewrite/pull/3613
Through something like
doAfterVisit(new RemoveEmptyXmlTags().getVisitor());
Am I correct in thinking 9fed57a465e7bd70f546bbb67c824abbd7ff4f69 resolves this issue?
Indeed that's tackled since! Thanks for helping clear out the backlog. 🙏