Tim te Beek

Results 1243 comments of Tim te Beek

Sorry to hear; Are there any missing types perhaps that differ between 21 and 21? Useing the [Find missing types recipe](https://docs.openrewrite.org/recipes/java/search/findmissingtypes), and [the data table it produces](https://docs.moderne.io/user-documentation/data-tables), do you find...

Thanks @ppkarwasz ! The bot suggestions can be a little confusing at times; it wants you to place the static imports last if that was unclear before. I'll try to...

Indeed seems like a decent extension of the existing recipe. There's some limitations of course when we can apply such a code change, but good suggestion for the limited cases.

As helpfully pointed out in #239 this should instead be covered by https://docs.openrewrite.org/recipes/java/logging/slf4j/slf4jlogshouldbeconstant Hope that helps!

So while similar these two recipes look to cover slightly different cases: - https://docs.openrewrite.org/recipes/java/logging/slf4j/slf4jlogshouldbeconstant - https://docs.openrewrite.org/recipes/java/logging/parameterizedlogging The first focuses mostly on String.format, whereas the second looks at string concatenation. Together...

Thanks for logging the issue as well @triceo . @greg-at-moderne FYI: this might factor in with the work you're looking at for Refaster as well: if the type information incorrectly...

hi @pankratz76 ; appreciate the help; it's been proving difficult to get to all the reviews lately, and then we tend to prioritize those that fix an issue or add...

Hi @traceyyoshima ; thanks for the suggestion! There's been a few such discussions in the past indeed, notably around - https://github.com/openrewrite/rewrite-kotlin/issues/25 - https://errorprone.info/docs/inlineme The second one is more geared towards...

Indeed makes things quite a bit easier. Could then be a single recipe that for instance already supports that `@InlineMe`, or a limited subset of those, to do the one...

hi @traceyyoshima ; this has now been implemented and proven to work: - https://github.com/openrewrite/rewrite-migrate-java/pull/788#issuecomment-3200452153 Hope that helps you there!