Tim te Beek

Results 1243 comments of Tim te Beek

Thanks for pointing this out @reftel ; Indeed support has improved to the point where we can possibly remove that page. Thanks!

Let's just remove the entire page for now, and any links to it; thanks both!

Hi @addozhang ; Interesting suggestion! If I understand correctly you'd want the generated source to participate in the scanning phase of any ScanningRecipe, but not be visited in the edit...

That helps a bit, thanks. Do I understand correctly you'd want to migrate the generated classes, and then from that point onwards maintain them and stop relying on the code...

Thanks for the suggestion; copying an earlier reply here: > it's a little more involved because we have to evaluate the flow leading into this whether all usages can be...

Thanks for the report! We're working on something similar in - https://github.com/openrewrite/rewrite/pull/4450 Lets see if we can resolve both of those in that same PR.

Hmm; wouldn't this be better served with a [precondition](https://docs.openrewrite.org/reference/yaml-format-reference#preconditions)? We've introduced that concept to prevent us from having to add similar options to multiple recipes, for the long term maintainability...

I'm not sure fully see the use case here, but that could also be because I have limited time to dive into the specifics. I do still feel that adding...

Appreciate the work and discussion here; it sounds like you've already found a solution using your internal `AddDependencyVisitor` and a precondition, and we agree the `specificModuleName` here is probably not...

Capturing the `nonRecursiveShouldIgnoreNestedWildcardImport` test failure output ```diff diff --git a/Foo.java b/Foo.java index 562edaa..d960c46 100644 --- a/Foo.java +++ b/Foo.java @@ -1,4 +1,4 @@ -import com.sun.net.ssl.internal.*; +import javax.net.ssl.internal.*; import javax.net.ssl.HostnameVerifier; class Foo...