Tommy Hofmann comments

Results 702 comments of


                                            Tommy Hofmann

Missing `hash` methods (or bad `==` methods)

updated

Missing `hash` methods (or bad `==` methods)

fixed in #1756

Add some comments in conjugate_quad(a::AbsSimpleNumFieldElem)

thanks

fix: don't use strange finite field

Part of #1918

Revert "Fix `@alias` test on nightly (#1612)"

Which tomorrow did you mean?

Make `should_show_banner` work with julia 1.11 and nightly

@benlorenz are you happy with this?

Make `should_show_banner` work with julia 1.11 and nightly

I think most of us would prefer a cleaner version, but I think no one has found one so far. I like the idea of wrapping it around `try/catch`.

fix a corner case

obligatory question: do you want to add your example as a test?

Add many `@req !is_trivial` checks

Is there a reason that residue rings, matrices and fraction fields are also restricted? I was mainly thinking about polynomials and series, because the code there is wrong.

Add many `@req !is_trivial` checks

It is correct for matrices. For fraction fields it gives errors in some situations, but no wrong results.