Tommy Hofmann
Tommy Hofmann
More Oscar woes: ``` Characteristic not known Stacktrace: [1] error(s::String) @ Base ./error.jl:35 [2] characteristic(R::AffineSchemeOpenSubschemeRing{AffineScheme{QQField, MPolyQuoRing{QQMPolyRingElem}}, AffineSchemeOpenSubscheme{AffineScheme{QQField, MPolyQuoRing{QQMPolyRingElem}}, QQField}}) @ AbstractAlgebra ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/src/NCRings.jl:165 [3] is_trivial(F::AffineSchemeOpenSubschemeRing{AffineScheme{QQField, MPolyQuoRing{QQMPolyRingElem}}, AffineSchemeOpenSubscheme{AffineScheme{QQField, MPolyQuoRing{QQMPolyRingElem}}, QQField}}) @ AbstractAlgebra...
The new `is_zero(one(R))` test is too good. Some things worked by accident before (due https://github.com/oscar-system/Oscar.jl/issues/4324), but now they won't because there is a genuine zero ring used as the coefficient...
Since we don't let Nemo overload `polynomial_ring_only` anymore, adding the `is_trivial` check here inside polynomial_ring_only` makes this check too coarse. Each polynomial ring type needs to implement this on their...
None at the moment, but with this approach here I cannot fix the generic ones without fixing the Nemo ones.
Do you plan to handle unions? I noticed that `fq_default` is missing. (And the `_template` should probably be moved to `etc/` too.)
In #3701 it was just arithmetic. Here it is a Gröbner basis computation, which, as far as I understand, seems to go via the functionality in Singular for arbitrary fields....
Not much too add except for saying, that I (and I know also @fieker) would love to see a ball version of padics with proper ball semantics. The current `padic`...
@fieker Just a breadcrumb: It seems that we are often running into saturation and are trying to compute roots of large elements: ``` for i in 1:100 begin Qx, x...
Probably the same problem as the following. On master: ``` julia> Qx, x = QQ["x"]; julia> f = x^6 - 7*x^4 + 14*x^2 - 7; julia> K, _a = number_field(f;...