Tommy Hofmann
Tommy Hofmann
`SparseArrays` is also taking forever and we only provide a constructor `SMat` to `SparseArray`. I guess both could be put in a package extension?
Yes, we can also ditch importing `nnz`. It does not matter which symbol it is. Very unfortunate that AbstractAlgebra depends on SparseArrays.
(I also wanted to suggest putting `@inferred` right of the comparison in the AA PR.) Thanks. Now we have to fix those inference issues. Because you started with this, I...
It is still a bit slowish, so I will keep it open.
Hm, this looks overly complicated. There is an `arb_max` (in flint), which gives a correct version of the maximum for two values. Once one uses this to implement `max`, one...
I can add it later today to Nemo.
https://github.com/Nemocas/Nemo.jl/pull/2200 As I wrote, this will make `maximum` just work.
Some (hypothetical) application: Look for combinations with specific properties. Then one iterates and aborts once something is found. Not sure how realistic this though. No one has complained so far.
(And we should make the error message for `length(it)` mention `number_of_combinations`.)
I played around a bit with `GF(5^(5^k))`. For Oscar/Nemo/flint the time is the same time its takes to find a random (dense) irreducible polynomial of degree 3125. On the other...