Tommy Hofmann
Tommy Hofmann
Yes: ``` julia> F = free_group(2) Free group of rank 2 julia> x, y = gens(F); julia> QF = group_algebra(QQ, F; sparse = true) Group algebra of free group of...
Thanks for the comments. I think I addressed them all. I also removed the `sparse` option from the user-facing version. It is now chosen automatically (as in Magma).
Note that this does not address all of the problems, since it is still possible to compare elements with the same type but different parents.
What do you suggest as a way forward if we actually need an iterator?
hm, I just pushed an iterator version here was this the right thing to do?
I can add it to Oscar and revert it here. But if the plan is as you described, doesn't it make this PR here obsolete?
Ah, the pointless lowering to `+(...)` strikes again. Should probably be a keyword argument instead of being removed.
I still want to do `sin(R(2), prec = 1000)` and not go via `set_precision(...)`. It is the same reason we allow `RR(2, precision = 200)`.
perfect, thanks I wonder if we need to deprecate this properly? Or would the argument against it be that it was not documented?
yes, I agree that for the arithmetic functions this is a bugfix. I personally don't mind if you switch to `precision = ` in a breaking release. I think `set!`...