Tommy Hofmann

Results 419 comments of Tommy Hofmann

Strange, flint_abort is definitely in Bill's repository. @fredrik-johansson Your solution does sound good. But we should ask @wbhart if he knows an alternative solution.

I am currently looking into it, @fredrik-johansson

Nice, thanks. It would be great if those `@label/@goto` would be rewritten. It seems they can just be replaced by simple `while` loops or `if` clauses.

The tests fail with `UndefVarError: disc_log not defined`. Either export `disc_log` or use `Hecke.disc_log` in the test.

I think it would be easier to use `Hecke.disc_log` and `Hecke.IdxCalc` in the tests.

It seems that the file `src/Sparse/DiscLog.jl` is never included in Hecke, so the tests are failing. The `include` calls should also be cleaned up. Files are included multiple times, which...

The real error is now here: https://github.com/thofma/Hecke.jl/runs/7443994926?check_suite_focus=true#step:6:629

Tests are failing. Note that you can run the tests locally by doing `Pkg.add("RandomExtensions")` (needs to be done only once) and then `Hecke.test_module("Sparse")`.

We would appreciate if you cite the article from 2017, where Hecke has been announced. Additional information on the specific version could be mentioned in the text.

I will close this for now. Please reopen if there is some remaining question.