Tommy Hofmann

Results 702 comments of Tommy Hofmann

I don't mind too much. Just noting that this has come up in the past in some other context: - https://github.com/oscar-system/Oscar.jl/issues/2657 - https://github.com/oscar-system/Oscar.jl/pull/2677

Can you elaborate? Here is how I understand it: The latex printer turns unicode characters into latex output with some heuristic. An implementor of `expressify(::MyType,..)` must insert unicode if he...

There is probably a misunderstand. Yes, unicode should only be printed if `is_unicode_allowed`. An implementor of `show` must respect this rule. If one wants to use `show` via `expressify`, then...

Yes, this is all working as intended. `context` is about capturing the `IOContext` and possible properties there. LaTeX output is controlled via MIME types. Both are orthogonal. If a user...

> expressify then decides to leave it as unicode, convert to latex, convert to ascii, etc. based on flags such as `is_unicode_allowed` Yes, this is exactly the current system. exxpressify...

In Hecke: ``` julia> factor(ZZ, QQ(1//100)) 1 * 5^-2 * 2^-2 ``` Regarding the `setindex!` and `mulpow!`. Yes, there is some overlapping functionality, but it is quite "natural" to have...

Because someone thought it was a good idea when it was implemented. But I guess we could change it, if there is some interest.

> @fieker says that the Flint documentation does clarify the conditions on the args. @fieker and I propose **removing** the current `reconstruct`, **and renaming** `unsafe_reconstruct` to `reconstruct`: this effectively eliminate...

Thanks to @fieker the methods were all consolidated in https://github.com/Nemocas/Nemo.jl/pull/2032 and subsequent PRs in Hecke (https://github.com/thofma/Hecke.jl/pull/1792) and Oscar (https://github.com/oscar-system/Oscar.jl/pull/4742). We used `_[induced_]rational_reconstruction` in Nemo to make it non-breaking. See also...

1. I might have missed it, but is there simple way to do the following? ``` julia> Qxy, = QQ[:x, :y]; julia> rand(Qxy, 1:10, 1:10, 1:10) # not a good...