Tommy Hofmann

Results 702 comments of Tommy Hofmann

Can you specifiy which polynomials we are talking about? Equality of multivariate polynomials in Nemo usually calls directly into flint and there is no `exponent_vectors` call.

Can you please post a full example to reproduce the slow equality test for MPolys?

Thanks for the clarification. The universal polynomial comparison is just missing a ``` if parent(data(a)) === parent(data(b)) return data(a) == data(b) end ``` right at the top. That should make...

We could optimize the comparison of those special elements (the "generators"), but for arbitrary elements it will still be slow. Would that help?

What is your use case? Often adding new variables? What is slow in the current implementation is when a new variable is added and then "new elements" are compared with...

I added some of the improvements over at https://github.com/Nemocas/AbstractAlgebra.jl/pull/2028. Should make comparison of "generators" much quicker.

Out of curiosity, why did you expect those to exist? Are these functions used somewhere in the documentation or elsewhere?

Because I forgot that they are in the documentation.

Will be fixed in the next version. Thanks for your report.

https://github.com/thofma/Hecke.jl/pull/1639 without the other commit