Update Zone11 implementation
Purpose
This PR proposes an update of test case Zone11 implementation.
Context
Test case specification: https://github.com/zonemaster/zonemaster/pull/1415 Test scenarios specification: https://github.com/zonemaster/zonemaster/pull/1417
Changes
- Update implementation (test case, message tags, profile)
- Update unit tests
- Update unit test data
How to test this PR
Unit tests are updated and should pass.
@matsduf @marc-vanderwal thanks, I have updated the unit tests and this PR is now ready for review. In particular, see the handling of specific root hints for scenarios NO-SPF-ROOT-ZONE, NULL-SPF-ROOT-ZONE, NON-NULL-SPF-ROOT-ZONE in t/Test-zone11.t where everything is in one file but requires a bit more code.
@matsduf @marc-vanderwal thanks, I have updated the unit tests and this PR is now ready for review. In particular, see the handling of specific root hints for scenarios
NO-SPF-ROOT-ZONE, NULL-SPF-ROOT-ZONE, NON-NULL-SPF-ROOT-ZONEint/Test-zone11.twhere everything is in one file but requires a bit more code.
Have you considered using the model introduced in #1467 instead?
Given that the domain-specific language in #1467 is merged, why not use that? It also supports replacing the root hints on the fly for subsequent scenarios.
Have you considered using the model introduced in #1467 instead?
Unfortunately no, just because I am not familiar with it yet and we are on a short deadline. I will start using it for next releases though !
@matsduf @marc-vanderwal please re-review