Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Thanks @benbowler. The IB LGTM :white_check_mark: Please note, I made a small tweak to remove the reference to `enableAudienceGroup()` for the secondary users aspect, as I don't think we will...

Note that I've further updated the IB in response to the observations made here, https://github.com/google/site-kit-wp/issues/9096#issuecomment-2289159282, as the generic Selection Panel should indeed not know anything about audiences.

I've estimated this an 11 to allow for testing, which could potentially be a bit time consuming.

I've raised a question about this issue on its [Asana task](https://app.asana.com/0/1207894970935603/1208146362275136), and will hold off adding AC while we consider it further.

Hi @wpdarren @aaemnnosttv, I'm assigning this to you for visibility, please can you take a look at the linked Asana task when you have a moment?

Thanks @aaemnnosttv! I've added AC for this issue, including a more contextually relevant link as per your suggestion on Asana.

Hi @mohitwp, thanks for checking in on this. The "Display visitor groups in the dashboard" setting is per-user, not a global setting, so the behaviour you are seeing is as...

> My thinking here is that something can be in partial data state for a 28-day range, but still can have all the data it needs for a 7-day range...

Thanks @nfmohit and @hussain-t, I have replied to the question about the notifications, please see this https://github.com/google/site-kit-wp/pull/8954#discussion_r1680782051.