Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Implement the unhappy path for Selection Panel audience count retrieval (error notice above footer)

Thanks @hussain-t - let's keep this assigned to me, but don't forget that as co-lead on the epic @kuasha420 can also review the IBs so they can generally be left...

Implement the unhappy path for Selection Panel audience count retrieval (error notice above footer)

Hi @hussain-t, thanks for drafting this IB. A few points: - It's worth noting that the IB for #8157 hasn't been finalised, and is subject to change (in fact it's...

Implement the unhappy path for Selection Panel audience count retrieval (error notice above footer)

Thanks @hussain-t! IB :white_check_mark:

Extend Consent Mode conditions for determining Ads connection status.

I've raised the priority of this one as it appears that users who have Ads linked with their Analytics account are seeing a drop off in tracking without Consent Mode...

Extend Consent Mode conditions for determining Ads connection status.

Thanks @aaemnnosttv, good spot there. I've added an additional point to the IB to make sure we don't miss this.

Audience Selection Panel rendered before the feature has been set up

Thanks for spotting that, @nfmohit! It was indeed a typo, which I've fixed. Back to you for another pass :)

Partial data badges showing incorrectly when property is in partial data state

IB ✅

Partial data badges showing incorrectly when property is in partial data state

Hi @kelvinballoo, thanks for spotting this! We someone managed to miss that one. I've created a followup PR to address the issue: https://github.com/google/site-kit-wp/pull/9554

Temporarily hidden tiles reappear and the “Temporarily hidden” badge is still visible after deselecting an active tile

Thanks @nfmohit, your read of the ACs is correct and it is indeed expected that a hidden audience will reappear when there are no other tiles to display. The IB...

Add the “New” badges to the Selection Panel

Hey @benbowler, while reviewing the IB here I've realised I left an important detail out of the AC. The "New" badges should only appear for audiences which have been created...