site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Implement audience settings setup CTA

Open nfmohit opened this issue 1 year ago • 2 comments

Summary

Addresses issue:

  • #8178

Relevant technical choices

This PR implements the audience settings setup CTA including its happy path behaviour.

PR Author Checklist

  • [ ] My code is tested and passes existing unit tests.
  • [ ] My code has an appropriate set of unit tests which all pass.
  • [ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • [ ] My code follows the WordPress coding standards.
  • [ ] My code has proper inline documentation.
  • [ ] I have added a QA Brief on the issue linked above.
  • [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • [ ] Run the code.
  • [ ] Ensure the acceptance criteria are satisfied.
  • [ ] Reassess the implementation with the IB.
  • [ ] Ensure no unrelated changes are included.
  • [ ] Ensure CI checks pass.
  • [ ] Check Storybook where applicable.
  • [ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

  • [ ] Ensure the PR has the correct target branch.
  • [ ] Double-check that the PR is okay to be merged.
  • [ ] Ensure the corresponding issue has a ZenHub release assigned.
  • [ ] Add a changelog message to the issue.

nfmohit avatar Jul 02 '24 18:07 nfmohit

Build files for 18c72819577c75a3c3ab3303239840c53767cf0b have been deleted.

github-actions[bot] avatar Jul 02 '24 18:07 github-actions[bot]

Size Change: +13.4 kB (+0.81%)

Total Size: 1.66 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 55.4 kB +59 B (+0.11%)
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B +4 B (+0.48%)
./dist/assets/js/googlesitekit-activation-********************.js 23.7 kB +22 B (+0.09%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.2 kB +3 B (+0.01%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.5 kB +56 B (+0.16%)
./dist/assets/js/googlesitekit-api-********************.js 10 kB -10 B (-0.1%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB -2 B (-0.03%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB -3 B (-0.03%)
./dist/assets/js/googlesitekit-data-********************.js 2.35 kB -1 B (-0.04%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.03 kB -7 B (-0.08%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB +1 B (+0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.3 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.98 kB -7 B (-0.07%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.1 kB +98 B (+0.39%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 76.8 kB -91 B (-0.12%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 141 kB +195 B (+0.14%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB +46 B (+0.16%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 113 kB -33 B (-0.03%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 162 kB +883 B (+0.55%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB +16 B (+0.07%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 12.8 kB +299 B (+2.39%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.1 kB -91 B (-0.16%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB -18 B (-0.06%)
./dist/assets/js/googlesitekit-settings-********************.js 73.5 kB +10.8 kB (+17.24%) ⚠️
./dist/assets/js/googlesitekit-splash-********************.js 73.4 kB +358 B (+0.49%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.3 kB -1 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB -9 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 78.5 kB +784 B (+1.01%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.4 kB -12 B (-0.02%)
./dist/assets/js/runtime-********************.js 1.3 kB -1 B (-0.08%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 645 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 731 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 674 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-notifications-********************.js 1.69 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 376 B

compressed-size-action

github-actions[bot] avatar Jul 02 '24 18:07 github-actions[bot]

Thank you for your kind review on this, @hussain-t ! I've addressed all the points that you have raised, except for the one about showing or not showing the success notification in settings if groups were enabled in the main dashboard, where we are waiting for feedback from @techanvil.

nfmohit avatar Jul 16 '24 07:07 nfmohit

Thanks @nfmohit and @hussain-t, I have replied to the question about the notifications, please see this https://github.com/google/site-kit-wp/pull/8954#discussion_r1680782051.

techanvil avatar Jul 17 '24 10:07 techanvil