Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Noting that the AC has been tweaked to remove the requirement for _neither_ of the SK audiences to exist in order to show the notice. As discussed with @hussain-t during...

> I have one observation and it might not be directly under the scope of this ticket. Let me know if this needs fixing and thus, a new ticket: >...

I've moved this back to Backlog as the final [in-progress changes to the design doc](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit?disco=AAABJiKQwSo), relating to audience caching, will probably affect the AC for this one

The audience caching aspect of the design doc has been sufficiently finalised, and I've moved this back to AC.

Hey @kuasha420, thanks for drafting this IB. > * [ ] Update the logic for rendering `AudienceTiles` when `availableAudiencesSynced` is true in addition to the current `hasMatchingAudience`. ie. `if (...

Thanks @kuasha420, that's looking good. A couple of last points: - I've tweaked the IB to address a couple of minor copy/paste level issues, please review the recent edit and...

Thanks @kuasha420! I do think it's worthwhile in order to avoid making any requests while the widget is not in-view, which is our preferred pattern. That update LGTM. IB :white_check_mark:

Hi @ankitrox, nice work so far on the QAB here too. I'd suggest that it states to "repeat the above for the `publicationOnboardingState` and `publicationOnboardingStateLastSyncedAtMs` settings", or something along those...

I've moved this back to Backlog as the final [in-progress changes to the design doc](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit?disco=AAABJiKQwSo), relating to audience caching, might affect the AC/IB for this one.

The audience caching aspect of the design doc has been sufficiently finalised, I've updated the AC and moved this back to IB, as the existing IB will need an update....