tdb3
tdb3
ACK for 58cb22c83c1b72af7f3c580dc6261cf50e7ed2cb. Thanks for the great feature update. Verification steps taken below. Pulled 58cb22c83c1b72af7f3c580dc6261cf50e7ed2cb. Each of the seven cases (from above) exhibited expected behavior (i.e. non-2.0 requests match previous...
> @willcl-ark, @tdb3, any interest in re-acking? This seems like it could definitely be merged with another ack Definitely. I'll plan to take a look tonight.
> > may be an issue with some tests when `testdatadir` is provided a relative path > > I can't reproduce this problem. I tried both running the one test...
> @tdb3 - Ah, I bet the problem relates to `BDB`. I don't build that way. I don't know what's wrong, but just to verify one thing, the [build document](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#berkeley-db)...
> @tdb3 I force-pushed a fix, it turns out that Berkeley DB (BDB) doesn't work with a relative path, only absolute. So it's a one-line fix. Thanks for finding this...
> > Rebased. This has failed CI once when waiting for the disconnection after: > > ``` > > cur_mock_time += (HEADERS_RESPONSE_TIME + 1) > > ``` > > >...
re ACK bffbb176d8a4f545c26ff7e437ab33cb004852bb
re ACK for 59affd0bf9042d746a6b32739edb0cd45d28d569. Built and re-ran functional tests locally. All passed.
reACK for 368389d973a85d21aa9ebf030ef5e7f7ac5343de. Pulled, built, ran all unit/functional tests (all passed).
re ACK for 567cec9a05e1261e955535f734826b12341684b6. Pulled, built, ran all unit and functional tests (all passed). Re-ran the test actions (quote below) from https://github.com/bitcoin/bitcoin/pull/27375#pullrequestreview-1876248880 Overall, similar results were observed. Each test action...