tdb3
tdb3
> Played around with the `getorphantxs 1` output a bit regarding visualization. You can now plug your own `getorphantxs.json` (verbosity >=1) into this demo tool https://observablehq.com/d/a481f4ced64b7975. Produces something like this...
Updated to e6853592361341c27103ed74b25470ac1e098d6d to address comments from @hodlinator and @itornaza
Pushed b6368fc285bf00b3033061dcd4e29298b227c6df (rebases on top of fc642c33ef28829eda0119a0fe39fd9bc4b84051) Saw the following CI error for macOS 14 with e6853592361341c27103ed74b25470ac1e098d6d This seems like it could be related to PR #30684? ``` node0 2024-10-02T00:15:45.783638Z...
> Please report the CI failure. Issue #31019 opened
Updated to address comments from @glozow Removed default argument from `ParseVerbosity()`, cleaned up comments, and updated the functional test to check negative verbosity. ``` git range-diff fc642c33ef28829eda0119a0fe39fd9bc4b84051..b6368fc285bf00b3033061dcd4e29298b227c6df fc642c33ef28829eda0119a0fe39fd9bc4b84051..98c1536852d1de9a978b11046e7414e79ed40b46 ```
> Ran Doxygen and inspected `ParseVerbosity` docs to confirm `[in]`-parameters were handled well etc. Much appreciated
Thanks for the review @danielabrozzoni and @pablomartin4btc! > Tested on `mainnet`. Not sure if would be use cases to add other arguments on a follow-up (count, filter by node id)...
At the time of the failure, the PR commits were on top of commit a74bdeea1b8e27b2335f0f7da78006e87ecfb235 (Sept 2nd). I'm probably missing something, but it almost seemed like the CI job was...
> @tdb3 it might be helpful to share link to the full C.I logs? Thanks. Link now included in the description.
> The node is expected to fail with `Invalid value detected for '-wallet' or '-nowallet'` (that's what the test is testing), so that's not the problem. Right, the title was...