tdb3

Results 77 comments of tdb3

> Does this consider the scenario where bitcoin.conf has valid rpcauth params, but the user specifies -norpcauth or such on the command line to disable them? Thanks for taking a...

> Tested this. Bare `-rpcauth` cannot be used to reverse `-norpcauth`. Since `-rpcauth=somethingvalid` does reverse `-norpcauth` (including reinstating `-rpcauth` options prior to the `-norpcauth`), this seems like it should be...

Addressed comments from @naiyoma and @ryanofsky. Also rebased.

> Thanks! I've cherry-picked your commit, but reordered it to appear before the test introduction commit and changed the commit subject accordingly (introduce constant, instead of deduplicating). Let me know...

Thanks for reviewing. > Out of the scope of this PR, having played around `start`, `status`, `abort` subcommands, I'd add some more context in the results of the first 2....

> Forgot to mention that it would be nice to add some test checking `relevant_blocks` is returned by `scanblocks status` in `test/functional/rpc_scanblocks.py` if possible. It would be. I took a...

Thanks. Planning to touch this up soon.

> Any reason not to scope the new variables? [luke-jr@851d354](https://github.com/luke-jr/bitcoin/commit/851d354fc4f94695aabd12d21e470dc90d267b93) moved, thanks

> I think we could have a setmockcondition RPC that acts like the existing setmocktime RPC and lets tests toggle global state that could be useful for testing. Great idea....