tdb3

Results 77 comments of tdb3

> Actually, since these don't change on their own... maybe a separate RPC altogether? (later extended to allow some changes?) This option also makes sense to me. Maybe something like...

> > Are there any drawbacks to this? > > I didn't notice any. > > It's worth mentioning that the total amount of data stored in this database is...

CR ACK for a29e014eca3a1db6a6114a7b8ced5eb3e69035c1 This seems to work well for files with additional digits. Just a minor nit. Technically, without escaping the period in the regex, files with a character...

@jonatack @kevkevinpal, what are your thoughts on reopening PR #30106 and dropping the test runner `insuffient` spelling error from 30084? Seems like this PR (30084) is scoped to more than...

~~lint error is unrelated. Already discussed in https://github.com/bitcoin/bitcoin/pull/30084#issuecomment-2118676930 and https://github.com/bitcoin/bitcoin/pull/30106.~~ The warning is unrelated. I had overlooked the lint error and it is now fixed.

> > I'm partial to getnodeversion or getclientversion, since RPC is implicitly versioned by the major version of the client/node > > The problem with those, imo, is that `client`...

> > How about squashing some of these changes to help keep the master branch commit log cleaner? > > Done Looks like b382bf4755e2b503cb1ee2f87a7b0f66dc5b76f4 adds the if, then d2e86117bc6004515ec72e55b2ec57304a31c0eb removes...

The guide is looking great! I dry ran it through the `2. V3 Transactions TRUC` section so far. Love how the guide explains the "why" and "what" is being done...

## Behavior Comparison (master (2aff9a36c352640a263e8b5de469710f7e80eb54) vs PR): ### CLI: 1) one valid rpcauth ``` src/bitcoind -regtest -rpcauth=user1:6dd184e5e69271fdd69103464630014f\$eb3d7ce67c4d1ff3564270519b03b636c0291012692a5fa3dd1d2075daedd07b ``` current: bitcoind starts, rpcauth usable new: no change 2) one empty rpcauth...

Reviewers can reorder the commits locally (e.g. interactive rebase) or cherry pick to master to see test failure before the fix. If desired, I could also squash the test commits...