tdb3
tdb3
> 🐙 This pull request conflicts with the target branch and [needs rebase](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes). Rebased to address conflict
> The rebase is wrong. Thank you. Looks like I had overlooked the addition of `wallet_util` (`TEST_FRAMEWORK_MODULES` being moved to feature_framework_unit_tests.py made it less obvious). Will rebase/push soon.
Rebased and pushed.
Thanks for the review @davidgumberg! Added the suggestions (force pushed). Responses inline.
Thank you for the review @cbergqvist! Implemented your suggestions and rebased.
> ACK [cb4f9fc](https://github.com/bitcoin/bitcoin/pull/29521/commits/cb4f9fc5847a7e53fe45d54b1fddf504dee5af82) Thank you for the review and testing @rkrux! Will add a note to the description about usage of port 0 now considered invalid.
> Tested ACK. The new error handling code looks good to me upon review. Ran the daemon and gave invalid values for `rpcconnect` and `rpcport` and the proper error messages...
Seeing a CI error for arm-linux-gnueabihf-g++ (on a line unchanged in this latest push). Will look into this. ``` In function ‘UniValue CallRPC(BaseRequestHandler*, const std::string&, const std::vector&, const std::optional&)’, inlined...
This is a great feature. Would love to see it get close to merge. Looks like the CI logs might be gone? Maybe this CI could be nudged to run...
> I wonder if a sub-object would be a good idea before we start adding more settings here. There's at least also `m_expiry` that would make sense to add too....