tdb3
tdb3
Existing behavior: ``` src/bitcoind -rpcallowip=127.0.0.1 -rpcbind=127.0.0.1:18000 -rpcbind=[::1]:18001 -rpcbind=127.0.0.1:notaport -rpcbind=127.0.0.1:-18002 -rpcbind=[::1]:-18003 ... 2024-08-21T02:44:13Z Command-line arg: rpcallowip="127.0.0.1" 2024-08-21T02:44:13Z Command-line arg: rpcbind="127.0.0.1:18000" 2024-08-21T02:44:13Z Command-line arg: rpcbind="[::1]:18001" 2024-08-21T02:44:13Z Command-line arg: rpcbind="127.0.0.1:notaport" 2024-08-21T02:44:13Z Command-line arg:...
> I think it would be good to keep the new `return false` and error log in `HTTPBindAddresses`. But a more direct fix for this issue might be to just...
> Hey, I'm reviewing this PR, and I saw that the test `run_invalid_bind_test` you implemented in `rpc_bind.py` is not invoking without explicitly providing the `--ipv4` or `--ipv6` flags, so is...
Rebased to address conflict from #30868
> > Concept ACK Thanks, this is useful! I'm uncertain if this check is better suited for `p2p_orphan_handling` or `rpc_getorphantxs` (or for a `feature_orphanage` or `mempool_orphanage`). If `p2p_orphan_handling` is the...
> @tdb3 reasonable suggestion, shouldn't take much effort? Yeah, I think it would just be moving the logic over to `p2p_orphan_handling`.
Seems worth experimenting with: https://github.com/bitcoin/bitcoin/blob/fa460884406b35b0dee75af23f42e8b4c4acbebc/src%2Fstreams.cpp#L76-L80 I wonder if the array creation, the copy, or the xoring here are the long pole in the tent? Experimenting with the all 0s xor...