Michaël Zasso

@nodejs/cpp-reviewers

@nodejs/platform-riscv64

This is done for Node.js 24. Can we close the issue?

With https://github.com/nodejs/node/pull/53078#discussion_r1609831586 in mind, is there a legitimate use case for the flag?

@nodejs/platform-windows there's one little error for now: ``` D:\a\node\node\deps\v8\src\flags\flag-definitions.h(3061,1): error C1070: mismatched #if/#endif pair in file 'D:\a\node\node\deps\v8\src\flags\flag-definitions.h' [D:\a\node\node\tools\v8_gypfiles\torque_base.vcxproj] ```

@StefanStojanovic Not sure what's wrong with your local tests but Windows CI is green!

``` 09:04:45 [1745/2474] ccache g++ -MD -MF obj/v8_base_without_compiler/turboshaft-graph-interface.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE -D_GLIBCXX_ASSERTIONS=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE -DV8_INTL_SUPPORT -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_SHARED_RO_HEAP -DV8_WIN64_UNWINDING_INFO...

@miladfarca Oh yeah I forgot to look at the floating patches we already have in `deps/v8`. Thanks!

https://github.com/nodejs/node/blob/4a54a80aa36dde4019f77ddab3cb419fc77bb90e/test/parallel/test-buffer-failed-alloc-typed-arrays.js#L15 The test tries to allocate a buffer of size `1e10`. This used to fail but is now possible after a V8 update.

It seems to break a few tests.