Michaël Zasso
Michaël Zasso
I think you're just seeing flakes. This test didn't fail in https://ci.nodejs.org/job/node-test-pull-request/59440
More specifically, the data comes from ICU (a dependency of V8).
Looks like some things are broken.
I just had to force-push `canary-base` to remove https://github.com/nodejs/node/commit/919759814bf039168ca21100bc39c167b93575da (it's now on main).
https://github.com/v8/node/pull/187 may be relevant
I don't know if it's related but there are many crashes with heapdump/heapsnapshot tests: https://ci.nodejs.org/job/node-test-commit-arm-debug/13095/
There isn't really a policy. From my PoV, if it is brings us towards a passing canary build, this can land.
I updated `canary-base` so it includes https://github.com/v8/v8/commit/300451e869ae908f9a454c5a265162a6b3960b5d and pushed https://github.com/nodejs/node/commit/30329d06235a9f9733b1d4da479b403462d1b326 to it. Thank you!
@marco-ippolito I believe the comment has been addressed.
Landed in f88bf05819d5