Michaël Zasso
Michaël Zasso
If it still fails, I hope we can use this PR to collaborate on finding a real fix for https://github.com/nodejs/node/issues/45578.
``` === === 9 tests failed === Failed tests: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/sequential/test-single-executable-application.js out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/sequential/test-single-executable-application-assets.js out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/sequential/test-single-executable-application-assets-raw.js out/Release/node --test-reporter=spec --test-reporter-destination=stdout...
I hoped to get more information from a debug build but it's not reproducible with it!
`--debug-node` shows the same errors.
I suggest to wait for https://github.com/nodejs/node/pull/52406 and retry.
Guess based on the stack trace: ``` ==177986==ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete []) on 0x602000000050 #0 0x55c2c68b5acd in operator delete[](void*) (/home/runner/work/node/node/test/.tmp.4102/sea+0x1ab5acd) (BuildId: 790abd3d700c[5596](https://github.com/nodejs/node/actions/runs/8567708081/job/23480032918?pr=52374#step:6:5597)3374b7aaca574c0d1b29db72) #1 0x7f2067505b6c in std::__cxx11::collate::do_transform(char const*,...
@nodejs/cpp-reviewers Does this make sense to you? ``` [process 179535]: --- stderr --- ================================================================= ==179535==ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete) on 0x603000000430 #0 0x55a691aac89d in operator delete(void*) (/home/runner/work/node/node/test/.tmp.4156/sea+0x1eac89d) (BuildId:...
What I understand is it points to https://github.com/nodejs/node/blob/97627da32b79cb6ba6bfe8af576c47f30db4a672/src/node_options-inl.h#L119-L123 Where an array is allocated. Then somewhere we use `delete` instead of `delete[]` to deallocate it, but I don't see where it...
Since the problem only happens with SEA tests, where the binary is patched, it's possible that the debug output is a red herring.