Michaël Zasso
Michaël Zasso
Is this safe to land on v22.x with cf2bce63862d995d238802ff4a7a24966361360a ?
I don't see why npm couldn't create the directory when needed. It is in a path that belongs to the current user so permissions shouldn't be an issue
The bot is unmaintained and cannot be easily upgraded. IMO this qualifies as broken
I'm a little afraid of having a branch with two completely separate implementations of the feature depending on the options passed by the user. This LGTM if the end goal...
Corepack doesn't only exist to install yarn and pnpm. It manages multiple installed versions and ensures the right one is used based on the current project.
``` failed 10 out of 10 not ok 394 parallel/test-child-process-exec-any-shells-windows --- duration_ms: 662.63700 severity: fail exitcode: 1 stack: |- node:assert:991 throw newErr; ^ AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Command...
> Is it okay to remove a part of the test? No. We need to install Git bash. It's a requirement for running the tests: https://github.com/nodejs/node/blob/main/BUILDING.md#option-1-manual-install
Maybe @isheludko has the answer?
Feel free to propose more elaborate descriptions for the notable changes.
@joyeecheung The reproducible snapshot test [failed on Windows](https://ci.nodejs.org/job/node-test-binary-windows-js-suites/28349/) but this PR does not include https://github.com/nodejs/node/commit/4c730aed7f825af1691740663d599e9de5958f89