Michaël Zasso

Results 1686 comments of Michaël Zasso

Does the sorting affect the array in the global state? It really shouldn't

There are other less intrusive alternatives. I recommend to create derived state dynamically (after the useReducer call) that you pass in a context provider. We don't want the sorted array...

This PR will need to be updated now that the styling issues are fixed in react-science.

There's a problem (overflow) with the vertical toolbar: ![CleanShot 2023-10-23 at 10 23 56](https://github.com/cheminfo/nmrium/assets/2352663/b65b15d1-df30-4284-9f50-5f3fed6caaf9)

We don't "need" to use components from react-science, but the goal with that project is to build a good component library that is separate from nmrium to be more easily...

It was probably fixed after opening this issue, but the goal here is to replace uses of the [CheckBox](https://github.com/cheminfo/nmrium/blob/main/src/component/elements/CheckBox.tsx) component with the one from `react-science` (so in the end we...

Can you start by migrating all the other uses of the component (skip FormikCheckBox)? Before adding props to the API, we should understand why they are needed. The decision can...

Yes, but no. I would like to push so Formik itself is replaced with something else (probably react-hook-form as that's what we have experience with). The Formik project is dead.

They really only do a few bug fixes. There is no active maintenance. Anyway, we dropped Formik in our projects a long time ago for other reasons. Performance is one...

You just want to remove the dashed lines (and drop behavior) or also replace the grey rectangle? I'm asking because the current implementation is quite intricate and not easy to...