Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

Use Dialog from blueprintjs instead of `modal.show`

I need a concrete example of something that doesn't work if the modal is injected elsewhere.

Use Dialog from blueprintjs instead of `modal.show`

No it cannot but I don't see what is the issue with it

Use Dialog from blueprintjs instead of `modal.show`

The only thing that matters is where the modal is rendered/open inside nmrium, not where the portal will be in the dom

Use Dialog from blueprintjs instead of `modal.show`

I'm going to migrate one modal in nmrium to show the new API

Use Dialog from blueprintjs instead of `modal.show`

There's nothing in the Modal API that requires a button. You only need a state somewhere. The `useModal` is one of the biggest problems in NMRium, because it renders things...

Use Dialog from blueprintjs instead of `modal.show`

I renamed the issue to be more correct. We no longer have a modal component in react-science. The Dialog from blueprint is good.

Use Dialog from blueprintjs instead of `modal.show`

Can you point to an example?

Use Dialog from blueprintjs instead of `modal.show`

Do you have another example because this one is quite tricky and will require a big refactoring

Use Dialog from blueprintjs instead of `modal.show`

The problem with the current way it's done (context), is that it's not reactive. If something is changed in the React state while the Modal is open, the contents (or...

NMRium component props

I suggest 3.