Michaël Zasso
Michaël Zasso
It's a hypothesis. I don't really know what's happening.
Oh, results with latest Clang are much more interesting! https://github.com/nodejs/node/actions/runs/9106598364/job/25034057819?pr=52374
Here are all the errors from the above actions run ``` === release test-cli-node-options === Path: parallel/test-cli-node-options Error: Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-cli-node-options.js --- CRASHED (Signal: 11) ---...
We need to decide what to do with https://github.com/nodejs/node/blob/main/tools/icu/current_ver.dep if we can't use md5 anymore (I don't know what's the purpose of that file)
We can question what the tests are doing, but `path` is a very sensitive module (especially security-wise) so I'm actually glad that they caught what could be regressions introduced by...
I think you can also add the `--preserve-symlinks-main` flag to avoid having to create the main file outside of the symlinked folder.
@nodejs/http2
@nodejs/python
Try to change: https://github.com/nodejs/node/blob/dcebac8885762c9e37a1a197bab847c8ee4d0bcc/common.gypi#L623
It looks like the commit message was edited when it landed on v22.x: https://github.com/nodejs/node/commit/3a0fcbb17a6dc37ac7463c01cdc0d633e4ac026b I'm marking this as backported so it doesn't show up in `branch-diff`'s output.