Jimmy Jia

Results 389 comments of Jimmy Jia
trafficstars

sure, we'd take a PR for this

Could bad things happen with SSR if using cWM? Since cWUM will never get called, and the default modal manager is a global singleton...

feel free to PR this

i forget what this was now... it's possible we already fixed this, too

@jquense are you okay with this? this looks like a breaking change. alternatively, we'd need to keep supporting the old API as a deprecated thing for now. otherwise this would...

It shouldn't cause issues unless you have incompatible dependency ranges. You can always just regenerate the lockfile if you have dupe versions.

Do you have a CodePen or equivalent that demonstrates this issue?

You can try CodePen or JSFiddle as well.

i think that was the old, old implementation, and i recall it led to some weird edge cases @ramareddy12345 why not just set the container for the inner overlay to...