react-overlays icon indicating copy to clipboard operation
react-overlays copied to clipboard

make react-popper a peerDependency

Open rheydt opened this issue 6 years ago • 2 comments

react-popper is a popular package that many react-overlays users might already be using. By specifying it as a dependency instead of a peerDependency, your users may be forced to install multiple versions/copies of react-popper.

Please consider making this a peerDep instead of a regular dependency. Thanks!

rheydt avatar Jun 14 '19 13:06 rheydt

It shouldn't cause issues unless you have incompatible dependency ranges. You can always just regenerate the lockfile if you have dupe versions.

taion avatar Jun 14 '19 14:06 taion

likely that we will drop react-popper in the near future to use popper directly. react-popper is a great library, but for the limited use-cases here and thanks to hooks, it's probably lighter weight to use Popper directly now!

jquense avatar Jun 14 '19 14:06 jquense