Jimmy Jia

Results 389 comments of Jimmy Jia
trafficstars

Per your example in https://github.com/facebook/graphql/pull/509#issuecomment-417812394, though, we would need to coerce for every argument, no? `getPerson` expects an `ID`, while `getPeople` expects an `[ID]`. If we wrap `$id` above, then...

This is bigger than I thought it would be. The motivation here really is around concerns like https://github.com/graphql/graphql-relay-js/issues/20#issuecomment-135887330. Especially when using static queries that use variables for these things, such...

As discussed at the WG, the next step here is to spike an implementation in graphql-js to allow some benchmarking, and to evaluate the incremental change in code complexity.

Worth keeping an eye on https://github.com/facebook/relay/issues/541, since Relay doesn't actually _have_ subscription support yet.

To reiterate, I don't think it's a question of resourcing. It's just about impossible right now because the semantics defined for subscriptions in GraphQL are restricted to just having a...

Ah, I see. I take that back, then. Thanks.

For people on IE 9 or IE 10, would the removed functionality be easily provided by the same polyfills they'd use for React?

In previous versions we actually just injected the `active` prop to children: https://github.com/react-bootstrap/react-router-bootstrap/commit/2c28b9d8bb4b38af09417e42da7de411a5936f86#diff-7d608450e48ccf30094f19938db3948cL95 Could we just make that the behavior again?

so in other places i just have an `activePropName` prop on the container the bigger question might be "what's a good default?" and i think passing down the `active` prop...

We should have an `activePropName` prop on ``. If this is unset, then we can avoid passing down an `active` prop.