tagName is undefined

[grydstedt]

The siblings crawl done by the modal manager crashes sometimes in Safari. Scripts and libraries will add all sort of stuff into the body and by default the modal manager will use the body as container. This sometimes ends up crashing in safari.

Specfically: let isHidable = ({ nodeType, tagName }) => nodeType === 1 && BLACKLIST.indexOf(tagName.toLowerCase()) === -1;

tagName here is undefined sometimes. Also trying to access siblings like cross-origin iframes will throw a security error. Perhaps we can check if tagName is defined here?

[taion]

feel free to PR this

[pnkapadia6]

Hey @taion, I would like to submit a PR for this issue. Although, I wanted to confirm that we're going to ignore those containers without tagName and not hide them.

[taion]

i forget what this was now... it's possible we already fixed this, too