Jimmy Jia
Jimmy Jia
Is this a regression?
Regression from v1.2.0, I mean – in which case we'd be happy to take a PR here.
Hmm, is it supposed to be supported there? What does setting `offsetBottom` do here? I think this might have been an oversight on my part in forgetting to delete the...
The point of `` is if you want to make an affix "seem" like it's contained in another container div, as opposed to calculating the offsets yourself.
Okay, I see, you mean `offsetBottom` as in the offset from the bottom of the element when sticked. That makes sense. Care to submit a quick PR to fix?
@jquense should explicitly-specified `popperConfig` take precedence over our inferred options here?
eh... i'm not that bothered by the API. it's also more or less ubiquitous at this point. @TrySound would you be happier if we switched to `tiny-warning`?
You can shim this over yourself, no? Create your own component that itself uses `useRootClose`, and have it do the relevant `ref` handling.
Sounds great to me. Do we have a migration guide doc in this repo? If not, perhaps something like https://github.com/react-bootstrap/react-bootstrap/blob/master/www/src/pages/migrating.mdx / https://react-bootstrap.github.io/migrating/
I'm not sure... @jquense do you have thoughts here? I don't think we want to encourage still using the old API, but I haven't thought through all the implications