Jimmy Jia

Results 390 comments of Jimmy Jia
trafficstars

Huh, is there anything else that might show up in our `.d.ts` files? The people reporting e.g. issues in CI but not locally esp. around `` are making me suspicious.

It doesn't immediately sound unreasonable. @jquense?

For positional args, the same approach as in B007 should work – just prefix the argument with an underscore. Also, pragmatically, we should probably ignore `*args`. For keyword args, it's...

FWIW, I don't think the issue here necessarily is that one can't force a long name through to the database for truncation. The issue is more that, for previously-generated migrations,...

Sorry, I didn't mean to suggest that either SQLAlchemy or Alembic needed to fix anything. I'd advocate for "do nothing" here, because it's been long enough since 1.3 has landed...

This package needs to either specify an explicit dependency on core-js v2.x. Though in general, it's probably best not to use env with `useBuiltIns` for libraries regardless.

It's a moot point. You're depending on core-js v2 anyway, so those files will get pulled in no matter what. There's no way to avoid pulling in core-js v2; that...

Oops, accidentally deleted the branch. Didn't mean to do that. This PR is still as intended.

Got the benchmarks working too. I'm not sure how to run the Marshmallow test suite with this API, though. I'm sure I could figure something out. Still, how does this...