Jimmy Jia comments

Results 389 comments of


                                            Jimmy Jia

trafficstars

fix(actions): migrate deploy docs step to use external action

Wait, if https://github.com/JamesIves/github-pages-deploy-action/pull/13 was merged, do we still need that token?

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of RefHolder which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here

We need to add support for something like `nodeRef` like in RTG

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of RefHolder which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here

Would be happy to take a PR analogous to https://github.com/reactjs/react-transition-group/pull/559

Mistake in overlay-trigger documentation

We'd be happy to take a PR here. Alternatively, perhaps the API could expose a `props` thing. This also seems like it'd be a good fit for a hook.

Mistake in overlay-trigger documentation

oops, didn't mean to close

Mistake in overlay-trigger documentation

I think the issue is that we should document the props that `` here passes in, along with guidance on which props to spread through to DOM components. That's really...

Referenced component after one Portal?

We'd be glad to get a PR to the docs here.

It is need to know when menu will be rendered and had position

Pass in `popperConfig` to set detailed Popper options

It is need to know when menu will be rendered and had position

ah, okay. this should spread in `...popperConfig` as with `` then. can you send in a PR?

It is need to know when menu will be rendered and had position

thanks!