react-overlays icon indicating copy to clipboard operation
react-overlays copied to clipboard

restore usage dom-helper.ownerDocument in useRootClose like in RootCloseWrapper

Open Viktor-the-great opened this issue 5 years ago • 4 comments

Describe the bug

Dropdown inside iframe is not trigger "root close" for iframe document

To Reproduce

Steps to reproduce the behavior:

  1. Render Dropdown inside iframe
  2. Open Menu
  3. Click outside Menu (inside iframe)
  4. Menu is not closed

Expected behavior

Dropdown should closed

Viktor-the-great avatar Dec 06 '19 11:12 Viktor-the-great

Is this a regression?

taion avatar Dec 06 '19 13:12 taion

If regression is to restore functionality from v1.2.0, then yes

Viktor-the-great avatar Dec 09 '19 10:12 Viktor-the-great

Regression from v1.2.0, I mean – in which case we'd be happy to take a PR here.

taion avatar Dec 09 '19 19:12 taion

PR #751

Viktor-the-great avatar Dec 10 '19 09:12 Viktor-the-great