react-overlays icon indicating copy to clipboard operation
react-overlays copied to clipboard

Drop warning

Open TrySound opened this issue 6 years ago • 3 comments
trafficstars

I tend to remove warning because of confusing api. It's hard to say by which condition warning is shown. This package also requires babel plugin setup which is forgotted here. IMO it's much easier to just write console statement and choose either console.warn or console.error than dealing with this commonjs-only package.

TrySound avatar Sep 15 '19 11:09 TrySound

Hi @jquense @taion what do you think about this?

TrySound avatar Oct 01 '19 14:10 TrySound

eh... i'm not that bothered by the API. it's also more or less ubiquitous at this point.

@TrySound would you be happier if we switched to tiny-warning?

taion avatar Nov 13 '19 16:11 taion

I'm not really a fan of this convention anymore caz it's confused me a few times lately. Also tiny-warning uses console.warn which is kinda a breaking change. Though it's not me to decide :)

TrySound avatar Nov 13 '19 19:11 TrySound