Taiki Endo

Results 935 comments of Taiki Endo

First, I believe *deterministically* returning outputs that behave differently from inputs is an intended behavior of macros, and I think the discussion that that resistance to it may be necessary,...

Thanks for the PR. > ``` > Error: install-action does not support semver operators: '0.10.3 > ' > ``` > > The debug output showed the version was parsed as...

Opened https://github.com/taiki-e/install-action/pull/1366 to support whitespace separated list per https://github.com/taiki-e/install-action/pull/1147#issuecomment-3291116129.

Hmm, if you want to always install Rust crates from source, I recommend using [cache-cargo-install-action](https://github.com/taiki-e/cache-cargo-install-action) (which supports installation from git url and caching) instead of this action. (See also https://github.com/taiki-e/install-action/issues/66)

- The previous discussion was in https://github.com/taiki-e/pin-project/pull/34. - pin-project has a [test to check the behavior here](https://github.com/taiki-e/pin-project/blob/03821842f22c9046ba4ff5e13a76a14068272593/tests/repr_packed.rs.) - Btw, this doesn't affected to pin-project (not lite), as said in https://github.com/taiki-e/pin-project/pull/34#issuecomment-688801015....

@theemathas I think your issue is bug in the is_disaligned=true case, and our issue is about is_disaligned=false case.

In Rust with branch coverage enabled (`--branch`, #8):

I believe this is an issue on the rustc rather than the cargo-llvm-cov. Would you mind submitting an issue at https://github.com/rust-lang/rust?

> Are you referring to the fact that the uncovered else block isn’t highlighted on line 4? Yes. I'm not 100% certain that this should be considered a bug, but...

Closing in favor of upstream issue: https://github.com/rust-lang/rust/issues/137524