Taiki Endo

Results 935 comments of Taiki Endo

> This functionality currently does not support Node.js. It probably does not work in Web Worker either. https://github.com/rustwasm/wasm-bindgen/issues/1046 Also, there may be an issue mentioned here. https://github.com/tomaka/wasm-timer/issues/21#issuecomment-1484553707 (It would make...

I'm not the person who originally set up the CI for this crate... > See [here](https://github.com/smol-rs/event-listener/actions/runs/8604804600/job/23579695251?pr=129). It shows as "cancelled", is it an automatic cancellation or a manual cancellation by...

> error: package `tracing-core v0.1.34` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.63.0 I think `tracing` dependency should be optional....

> * a "take_until" method - It seems that what was actually added was an freestanding function (`stream::take_until`) not a trait method (`StreamExt::take_until`)? (The PR title and commit message also...

(Honestly, I have no strong opinion on which API to choose here. I just know what the result of inconsistent APIs can be: https://github.com/rust-lang/futures-rs/issues/2755)

I personally prefer not to use the Cargo feature for this purpose (and use cfg instead), as it is easy to get into trouble if there is a crate enabling...

Published in 2.5.0.

The cfg for that already exists long before that feature. Please read the readme or documentation: https://github.com/taiki-e/portable-atomic#optional-cfg-unsafe-assume-single-core https://docs.rs/portable-atomic/latest/portable_atomic/#optional-cfg-unsafe-assume-single-core > - **`--cfg portable_atomic_unsafe_assume_single_core`** > Since 1.4.0, this cfg is an alias...

I would be happy to accept PRs to rewrite the current document that makes it seem as if the Cargo feature is the main one, and make the use of...

Thanks. I yanked 1.9.0 now.