Taiki Endo
Taiki Endo
Thanks for the PR, but we have no interested on bumping MSRV for dev-deps (this is why we skipped criterion 0.5).
Yeah, we can keep this open. Our next MSRV bump will happen this summer or this fall to align with the new Debian stable release.
Handled by https://github.com/smol-rs/async-io/pull/226 & https://github.com/smol-rs/async-io/pull/234. (When I actually tried it out, I found that MSRV bump wasn't necessary anywhere. I think you misunderstood [Clippy's false positive](https://github.com/rust-lang/rust-clippy/issues/12257#issuecomment-2093667187) as being genuine.) I'm...
> https://formulae.brew.sh/formula/valgrind exists. (It's x86_64 linux-only.) > IMO if snap is missing, using the system package for valgrind would be a good fallback. That seems reasonable to me.
AFAIK `cargo-bininstall` already fallback to `cargo install`. Or are you talking about something like https://github.com/taiki-e/install-action/issues/66?
> I think `derive_utils` doesn't handle generic traits for now right ? It is supported. I think it just needs to do the same thing as any other core::convert traits:...
Could you add a test case to tests/auto_enum.rs to check that this is actually working? This PR currently has tests for cases where compilation fails, but not for cases where...
> if I consume the FuturesUnordered as a Stream and there is no more futures inside it, it would return None but if then later I add a future, it...
> The `crossbeam-epoch` maintainer thinks that Miri does not support weak memory model very well yet. To be clear: As for consume memory ordering, I don't think it's a problem...
I think what we should do here is the same as what's proposed in ring. (i.e., vendoring the getrandom WASM code.)