Taiki Endo

Results 935 comments of Taiki Endo

The next MSRV bump will probably be to 1.85 or 1.86 when Debian 13 is released. It will probably be 4 to 8 months later. However, you probably don't need...

Could you elaborate on the behavior you are hoping for? If the key does not exist, what do you want it to be compared to?

cc @Tianion (who added compare_insert in https://github.com/crossbeam-rs/crossbeam/pull/976) Perhaps a good solution here would be to change the closure of `compare_insert` to take `Option`? or add new variant that do it?

I was thinking a closure that takes `Option` (`Some` if key is present, `None` if key is not present) could handle both use cases: - If the user want not...

Thanks for the report! Perhaps just removing the use of tracing in the following two places would suffice? https://github.com/smol-rs/polling/blob/dd7b2075dbc032a8a485687bc1703fe149f87fb2/src/epoll.rs#L259 https://github.com/smol-rs/polling/blob/dd7b2075dbc032a8a485687bc1703fe149f87fb2/src/kqueue.rs#L281 I think it's also reasonable to make tracing optional like...

(Related: https://github.com/rust-lang/rust/issues/29488.)

Thanks! I haven't reviewed the changes yet, but I'm very excited about this. Personally, I would prefer to support this as a subcommand (as said in https://github.com/taiki-e/cargo-llvm-cov/issues/221#issuecomment-1250553812), as I find...

Please read the documentation: https://docs.rs/auto_enums/latest/auto_enums/#stdcoreops > - [Fn](https://doc.rust-lang.org/std/ops/trait.Fn.html) (requires "fn_traits" and "unstable" crate features) > - [FnMut](https://doc.rust-lang.org/std/ops/trait.FnMut.html) (requires "fn_traits" and "unstable" crate features) > - [FnOnce](https://doc.rust-lang.org/std/ops/trait.FnOnce.html) (requires "fn_traits" and "unstable"...

I think this could be implemented by basically[^1] copying the existing cfg macros, always applying `cfg(...)` of `cfg_attr(feature = "fallback", cfg(...))`. https://github.com/taiki-e/portable-atomic/blob/9113456b11cd87dd5e489ccb368d5b47552f8594/src/cfgs.rs#L245 [^1]: The exceptions are architectures without atomic CAS...