Taiki Endo
Taiki Endo
Sounds reasonable to me.
@TroyKomodo --no-clean is unrelated to the incremental compilation of rustc itself, but improves the performance of successive builds, since the cleanup to prevent false positives in several situations that occur...
> What should an invocation look like? I have no strong opinion about this, but I thought something like --no-clean=\.
I agree with adding an option to `clean` subcommand is more reasonable.
Thanks for the PR! It is difficult to implement scoped threads correctly and this implementation is also unsound. Consider the following test case (based on https://github.com/crossbeam-rs/crossbeam/pull/844#issuecomment-1143288972). ```rs // tests/thread_api.rs #[test]...
@Altair-Bueno Btw, as for https://github.com/tokio-rs/bytes/issues/461, it has already been explained in related PRs some times (e.g., see https://github.com/tokio-rs/bytes/pull/573#issuecomment-1271567631) that it can be addressed without requiring any breaking changes.
Automating the generation of the list is a good idea! > https://github.com/snapbuy/uv/blob/2e3d7669c31f1b96d7fd92bc0b349230b20203a8/crates/platform-host/src/linux.rs I don't know why you are posting a link to a random fork of uv, but a simple...
> your thoughts about this Is this about downgrading? Downgrading can cause security issues, so I don't think it should be discussed in the same way as other issues here....
It seems that supporting Into/TryInto is fine. I would accept a PR to do that.
> As for `TryInto` (which I'll probably do in a 2nd PR) how do you think the error type should be treated? > > Should it be named `enum_derive(TryInto)`? Should...