Taiki Endo
Taiki Endo
Thanks for the PR! - This appears to bypass #43 well, which is interesting. - This currently requires allocation, which is unfortunate given that there are APIs such as format_args...
Adding `Debug`/`Display` (or `Debugable`/`Displayable` mentioned in https://github.com/tokio-rs/valuable/issues/43#issuecomment-854111197) variant to `valuable::Value` and then adding `#[valuable(debug)]`/`#[valuable(display)]` that pass the field as `Value::Debug`/`Value::Display` to derive seem to good idea to me.
To be honest, I personally am not very happy with allowing execution of arbitrary code. If there is really no other way to support it then I guess we have...
I thought that Microsoft itself was moving away from UWP. If so, I think they are still maintaining it for compatibility, but it is unclear if it is worth our...
As for `sync` and `iter` modules, there was a discussion that both `alloc::sync::atomic` and `alloc::iter` look strange at https://github.com/rust-lang/rust/pull/58175. (it is listed as a unresolved question in [RFC2480](https://github.com/rust-lang/rfcs/blob/master/text/2480-liballoc.md#unresolved-questions))
A common bug with *_many functions in Rust is that memory safety is violated when the iterator panics. So could you please add a Miri-compatible test for such a case?...
It seems miri reported memory leaks. ``` error: memory leaked: alloc44788 (Rust heap, size: 120, align: 8), allocated here: ``` https://github.com/smol-rs/async-executor/actions/runs/7999577501/job/21847610801?pr=92
AFAIK, async-io doesn't use slab APIs that requires 0.4.7, but it is okay with using the same version requirements to keep things simple.
Closing per https://github.com/smol-rs/async-io/pull/206#issuecomment-2395519295 (now confirmed by the check added in https://github.com/smol-rs/async-io/commit/c86a47783435ed2c5adfe970d353c32996a56e3a).
https://github.com/smol-rs/async-io/actions/runs/6358096463/job/17270021140#step:11:44 ``` Running unittests src/lib.rs (target/wasm32-unknown-unknown/debug/deps/async_io-1a608e2b038c59[41](https://github.com/smol-rs/async-io/actions/runs/6358096463/job/17270021140#step:11:42).wasm) no tests to run! Running tests/async.rs (target/wasm32-unknown-unknown/debug/deps/async-6cc94a735e74c985.wasm) no tests to run! Running tests/block_on.rs (target/wasm32-unknown-unknown/debug/deps/block_on-0[44](https://github.com/smol-rs/async-io/actions/runs/6358096463/job/17270021140#step:11:45)b18783949e5c2.wasm) no tests to run! Running tests/timer.rs (target/wasm32-unknown-unknown/debug/deps/timer-2[47](https://github.com/smol-rs/async-io/actions/runs/6358096463/job/17270021140#step:11:48)dda665b5d544f.wasm) this test suite...