Taiki Endo

Results 938 comments of Taiki Endo

> async-trait modifies the method signature, but not the body Ah, this isn't strictly correct because async-trait actually replaces `self` argument and `Self` keyword. However, `self` argument can be passed...

I could reproduce this error by modified the code you gave. **Reproduction**: [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=fb6bca7f17eaf34b56c6ca9861894238) (Removed dependency on GAT and replaced traits/types that do not exist in scope with empty trait/type definitions)...

@wrckn Seems `'s` and type parameters need to outlive `'async_trait`, so it needs to add `'s: 'async_trait` bounds to methods and `$ty: 's` bounds to impls: [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=d564a8b04208a0d8c12f2434da4b8a41) (async-trait automatically adds...

I would suggest raising the MSRV of `macrotest` to 1.36 which is the MSRV of `serde_json`. This crate is a crate for testing and there doesn't seem to be much...

> Doesn't cargo just compile it twice? It will be compiled twice if the major versions (or minor versions if the major version is 0) are different. In other cases,...

This does not seem right because [the cargo feature should be additive](https://doc.rust-lang.org/cargo/reference/features.html#feature-unification). For example, enabling this feature may break dependencies that do not enable this feature because some signatures of...

It is an issue of crossbeam (see https://github.com/crossbeam-rs/crossbeam/issues/803), and is unrelated to this repository.

r? @crossbeam-rs/admins (Any objections to this?)

@RalfJung: I believe the original SB violation reported in this issue (https://github.com/rust-lang/rust/issues/55005) no longer exists, but there are several other SB violations. One is the use of pointers that went...

I have investigated the problem of such before ([atomic-memcpy](https://github.com/taiki-e/atomic-memcpy)) and there are two main problems with the approach that uses AtomicU8. - reads and writes as AtomicU8 slice are very...