Markus Staab
Markus Staab
please add a test case
> Seems like the 7.3 and 7.4 errors test errors were introduced in #3128 ?? fixed the build error with https://github.com/phpstan/phpstan-src/pull/3137
> If you have hundreds of mutants, it ain't going to be that nice to have your screen flooded with reports. agree > If you have hundreds of mutants, it...
> also, as a possible option, if no logs are configured and `-s` is not provided, we can not only add a TIP, but ask user to enable it on...
I am not yet sold on the "interactive question", as I think it can be quite annoying. what about turning `show-mutations` into a int-option instead/in-addition to being a bool option?...
> We can show a sample of mutation: there's an [implementation of the reservoir sampling](https://github.com/sanmai/pipeline/blob/491b172349d77c9e2f2f2aa1791c9de95bfd1abe/src/Standard.php#L924) algo in the pipeline library. It can also be weighted sample, if we want to...
> I like the idea of `--show-mutations=int|'max'` I will provide a POC. > We can show a sample of mutation I think this should be a followup after we have...
closing here. [opened a followup regarding the limiting/sampling suggestion](https://github.com/infection/infection/issues/2235)
> While the idea itself is interesting in exploring, I want to highlight that we do a lot of assertions for `$this->output->writeln()` because in some classes it's the main logic...
Another example in which I think mutations only sometimes make sense (meaning such mutations should happen on a higher level) project class extends a 3rd party class ```diff 3) /Users/staabm/workspace/infection/src/Command/BaseCommand.php:68...