Markus Staab

Results 959 comments of Markus Staab

I guess its kind-of a similar problem I tried to fix in https://github.com/phpstan/phpstan-deprecation-rules/pull/37 - in which phpstan did not error on deprecated `__toString()` magic invocations, as it does not yet...

I like the suggestion, would add a small thing in the dropdown 2.0.0 - _contains backwards incompatible changes_ 1.1.0 - _new features included_ 1.0.1 - _bugfixes only_ As guidance

should I do the same for all other repos?

memo to me: the changes need to be in `.gitattributes` as ondrey pointed out > for a new tool/GitHub action to check this :) I will see what I can...

> The reason was really simple: `*.json` was catching all json files - including e. g. `composer.json`. I think we should improve the json file loading so a more useful...

the reported exception should be able to tell the user with which file a problem occured

could you provide a full repro? wheter a call to `trigger_deprecation` triggers a phpstan error depends on all the given arguments and additionally depends on your composer.json version constraints

I wonder whether this is a expected AST, or whether its a bug in nikic/php-parser

ich vermute das ist ein duplicate von https://github.com/phpstan/phpstan/issues/9295#issuecomment-1542186125