Markus Staab

Results 1100 comments of Markus Staab
trafficstars

I think we could discuss at least these ones - which look like low hanging fruit ```diff 1) /Users/staabm/workspace/infection/src/Foo.php:40 [M] TrueValue @@ @@ { function doFoo($x) { - echo $x...

> I would like @infection/core to participate here, as you are touching a very complex topics. absolutely. I am just dumping ideas for discussions and I am also fine if...

> When working with really big projects, performance issues often arise. They can be solved with some techniques, such as sequential file processing. This was my main motivation for this...

I think you should use generics: https://phpstan.org/r/c3562717-43a9-4f1c-ad23-416386d1afe2

do you run the tool from its sources, or did you install a stable release [it like described in the readme](https://github.com/TomasVotruba/phpstan-bodyscan?tab=readme-ov-file#install)?

I think these deprecations should be fixed with cs fixer over the whole codebase (maybe also other sabre/* repos). since fixing this error is backwards compatible we could do it...

Just want to say thank you ❤️ for working thru all the repo @phil-davis

will send a regression test in a few moments

this one get fixed with https://github.com/phpstan/phpstan-src/pull/4417

for deprecations you need phpstan-deprecation-rules